Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangram Checker Game added #4725

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Damini2004
Copy link
Contributor

PR Description πŸ“œ

Game added sucessfully.

Fixes #4563


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented Jul 1, 2024

Thank you @Damini2004 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pr should include only your game folder asset folder and main readme.md file

@Damini2004
Copy link
Contributor Author

@ishita-43 My pr doesnt contain game folder, assests,main readme ?

@ishita-43
Copy link
Collaborator

You should add your game image into asset folder of the repo and also add your game entry into main readme.md file of the repo

@ishita-43
Copy link
Collaborator

and your pr is showing 576+ files which is impossible forme to see errors instead you should add only your game folder and make pr on that after forking the repo and locally cloning that into your environment

@Damini2004
Copy link
Contributor Author

@ishita-43 idk but this repo having several problem while creating pr.

@ishita-43
Copy link
Collaborator

@ishita-43 idk but this repo having several problem while creating pr.

did you cloned the repo after forking on your local system

@Damini2004 Damini2004 requested a review from ishita-43 July 8, 2024 15:11
@ishita-43
Copy link
Collaborator

@ishita-43 idk but this repo having several problem while creating pr.

would you be able to make new pr request following the steps bellow - https://github.com/GSSoC24/Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Pangram Checker Game
3 participants